From 19d6e1e658f76c5f582abfd209ab4381d5ba20fe Mon Sep 17 00:00:00 2001 From: Rahul DMello Date: Sat, 22 Jun 2024 03:53:47 +0000 Subject: [PATCH 1/2] Increase buffer capacity for mutableRouterEvents flow within RibEventsIncrease buffer capacity for mutableRouterEvents flow within RibEvents --- android/gradle.properties | 2 +- .../rib-base/src/main/kotlin/com/uber/rib/core/RibEvents.kt | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/android/gradle.properties b/android/gradle.properties index 0959bc57a..80b839a12 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -13,7 +13,7 @@ # org.gradle.parallel=true GROUP=com.uber.rib -VERSION_NAME=0.16.3-SNAPSHOT +VERSION_NAME=0.16.4-SNAPSHOT POM_DESCRIPTION=RIBs is the cross-platform architecture behind many mobile apps at Uber. This framework is designed for mobile apps with a large number of engineers and nested states. POM_URL=https://github.com/uber/RIBs/ POM_SCM_URL=https://github.com/uber/RIBs/ diff --git a/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/RibEvents.kt b/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/RibEvents.kt index 47feba6e4..2178e8766 100644 --- a/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/RibEvents.kt +++ b/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/RibEvents.kt @@ -18,15 +18,16 @@ package com.uber.rib.core import androidx.annotation.VisibleForTesting import io.reactivex.Observable import kotlinx.coroutines.channels.BufferOverflow +import kotlinx.coroutines.channels.Channel import kotlinx.coroutines.flow.MutableSharedFlow import kotlinx.coroutines.rx2.asObservable public object RibEvents { private val mutableRouterEvents = - MutableSharedFlow(0, 1, BufferOverflow.DROP_OLDEST) + MutableSharedFlow(0, Channel.UNLIMITED, BufferOverflow.DROP_OLDEST) private val mutableRibDurationEvents = - MutableSharedFlow(0, 1, BufferOverflow.DROP_OLDEST) + MutableSharedFlow(0, Channel.UNLIMITED, BufferOverflow.DROP_OLDEST) @JvmStatic public val routerEvents: Observable = mutableRouterEvents.asObservable() From a7b33ad4ee4f605e8680f795e1621a2cb55ab075 Mon Sep 17 00:00:00 2001 From: Rahul DMello Date: Mon, 24 Jun 2024 19:07:16 -0400 Subject: [PATCH 2/2] Revert the version bump --- android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gradle.properties b/android/gradle.properties index 80b839a12..0959bc57a 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -13,7 +13,7 @@ # org.gradle.parallel=true GROUP=com.uber.rib -VERSION_NAME=0.16.4-SNAPSHOT +VERSION_NAME=0.16.3-SNAPSHOT POM_DESCRIPTION=RIBs is the cross-platform architecture behind many mobile apps at Uber. This framework is designed for mobile apps with a large number of engineers and nested states. POM_URL=https://github.com/uber/RIBs/ POM_SCM_URL=https://github.com/uber/RIBs/