Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React node/edges elements are not umounted? #321

Open
adamzapasnik opened this issue Jun 8, 2021 · 1 comment · May be fixed by #322
Open

React node/edges elements are not umounted? #321

adamzapasnik opened this issue Jun 8, 2021 · 1 comment · May be fixed by #322

Comments

@adamzapasnik
Copy link

adamzapasnik commented Jun 8, 2021 •
edited
Loading

Describe the bug
I notice that when I delete an edge or a node there is still a corresponding react element in react extension's Components view (or whatever you call it). It seems that you remove dom elements but you never call ReactDOM.unmountComponentAtNode. Is it on purpose? Isn't pretty much a memory leak? I could be wrong, so please explain why it's done this way.

To Reproduce
Steps to reproduce the behavior:

  1. Remove a node or an edge
  2. Look into react extension's Component sview
  3. Notice that there are still components "alive"

Expected behavior
They should be removed, I guess?

Screenshots
Screenshot 2021-06-08 at 22 15 41
Notice the NaNpx (an edge was removed, but the React component still exists?)

Desktop (please complete the following information):

  • OS: [e.g. iOS] macOs
  • Browser [e.g. chrome, safari] firefox/chrome
  • Version [e.g. 22] newest

Additional context
version 8.0.0-beta.6
node v14.17.0
@ajbogh
Copy link
Contributor

ajbogh commented Jun 9, 2021

Great catch. This wasn't intentional, just an oversight. Please feel free to submit a PR to fix this issue.

@adamzapasnik adamzapasnik linked a pull request Jun 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unmount React Components when removing elements from Dom adamzapasnik/react-digraph
2 participants
@ajbogh @adamzapasnik