Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete selected edge #93

Closed
philippov opened this issue Nov 20, 2018 · 5 comments
Closed

Can't delete selected edge #93

philippov opened this issue Nov 20, 2018 · 5 comments

Comments

@philippov
Copy link

I suppose handleDocumentClick fires when an edge is selected. So state.focused becomes false and delete doesn't work.

@ajbogh
Copy link
Contributor

ajbogh commented Dec 19, 2018

Hi @philippov. Is this happening with the latest react-digraph? I haven't seen any issues recently other than for edges that have the same target node as the parent (#101).

@pash90
Copy link

pash90 commented Feb 25, 2019

@ajbogh Any updates on this issue? I'm facing the same thing. Can't delete the selected edge.

@pash90
Copy link

pash90 commented Feb 25, 2019

@ajbogh @philippov This is the error I get.
image

image

Also to note, if I remove the onDeleteEdge custom handler that I am providing to GraphView, the error disappears and it starts working properly.

@ajbogh
Copy link
Contributor

ajbogh commented Feb 26, 2019

@pash90 I'm doing project cleanup duty this week, so I'll be checking out, commenting on, and closing a number of PRs. I sincerely hope to close this PR soon.

@pash90
Copy link

pash90 commented Feb 28, 2019

@ajbogh Much much appreciated brother!

@ajbogh ajbogh closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants