Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with damping for subregions #92

Open
mjoelln opened this issue Oct 8, 2024 · 1 comment
Open

Issue with damping for subregions #92

mjoelln opened this issue Oct 8, 2024 · 1 comment
Assignees

Comments

@mjoelln
Copy link

mjoelln commented Oct 8, 2024

Hi,

I work with a heterostructure simulation, in which I want to assign different damping constants "alpha" to different subregions. Using ubermag, it does work well with oommf, but not with mumax3c. The created .mx3 file shows for example alpha = {'region1': 0.01, 'region2': 0.2}. Changing line 27 and 52 in scripts\driver.py from
mx3 += f"alpha = {alpha}"
to this
mx3 += mc.scripts.set_parameter( parameter=alpha, name="alpha", system=system, ovf_format=ovf_format, )
worked for me. I assume this is a decent fix?

I'm a bit new to github/pull requests so I opened this as an issue first for someone to double check.

@lang-m
Copy link
Member

lang-m commented Oct 27, 2024

Hi @mjoelln, thanks for reporting the issue and proposing a fix, the proposed changes look good.

Feel free to open a PR. If you have any technical issues please ask. I can also add the required changes if you have difficulties creating the PR.

@lang-m lang-m self-assigned this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants