Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission wkhtmltopdf-binary gem fork #496

Closed
crowesn opened this issue May 10, 2024 · 1 comment · Fixed by #500
Closed

Decommission wkhtmltopdf-binary gem fork #496

crowesn opened this issue May 10, 2024 · 1 comment · Fixed by #500
Assignees
@crowesn

Comments

@crowesn
Copy link
Contributor

crowesn commented May 10, 2024

We created and started using a fork of the wkhtmltopdf binary gem. I submitted a PR to the parent from our fork last year and it was merged yesterday! So, I think we can look at decommissioning our fork and using the parent release of the gem.

See zakird/wkhtmltopdf_binary_gem#155
@crowesn crowesn added this to the Next deploy milestone May 10, 2024
@crowesn
Copy link
Contributor Author

crowesn commented May 13, 2024

zakird/wkhtmltopdf_binary_gem#155 (comment)

@crowesn crowesn self-assigned this May 13, 2024
@crowesn crowesn mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowesn crowesn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decommission wkhtmltopdf_binary fork uclibs/treatment_database
1 participant
@crowesn