Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When post operation takes long time, and the connection times out before the server returns a timeout or error, the error dialog shows "angular variables" instead of a message #16041

Open
simonech opened this issue Apr 12, 2024 · 4 comments

Comments

@simonech
Copy link
Contributor

simonech commented Apr 12, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.2, but it's been there forever

Bug summary

If any operation in the backend takes longer than the timeout of any proxy between browser and server, the error dialogue shows the angular variables instead of any possible error message.

Specifics

In our case, our Umbraco installation is protected by Cloudflare (no caching, just WAF), and after a while, Cloudflare returns a timeout error with a 524 HTTP error code and cuts the communication.

image image

Steps to reproduce

Behind cloudflare (and probably other proxies that might timeout), execute a long running operation that take longer than the timeout of the proxy, in my case is a save and publish operation.

Expected result / actual result

I would expect the dialogue to contain some actual error message, not the angular syntax. I understand you cannot add the real error because at this point we don't even know if the operation just took longer than 1 minute and was successful or eventually failed as well, but at least add something like "the connection timed out while waiting the server to respond" (or some less tech jargon)

While I get this
image

Copy link

Hi there @simonech!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Migaroez
Copy link
Contributor

Hey Simone, I can force the client into similar behavior by overwriting the contentController.PostSave method to return a 504 or 524 statusCode.

I agree that in these cases the client should show a more user friendly message that informs them of a possible failure because of network relation complications.

@Migaroez
Copy link
Contributor

Something similar happens in belissima
image

@simonech
Copy link
Contributor Author

Something similar happens in belissima

The message in v14 is a bit better than the one in v13. Here at least you get the error code '524' instead of the angular syntax.

But I think the message should say that there was a network related issue, but the operation has been submitted to the server and it would probably succeed, so there is no need to re-execute it.
Or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants