Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.2] Backoffice - Can't create Document Type Composition #17173

Closed
Borc92 opened this issue Oct 2, 2024 · 9 comments · Fixed by umbraco/UmbracoDocs#6497
Closed

[v14.2] Backoffice - Can't create Document Type Composition #17173

Borc92 opened this issue Oct 2, 2024 · 9 comments · Fixed by umbraco/UmbracoDocs#6497
Labels

Comments

@Borc92
Copy link

Borc92 commented Oct 2, 2024

Umbraco version:

14.2.0

Bug summary

With the freshly instaled version of u.14, there is no posibility to create an Composition under Document Types

It is even missing in the documentation in the printscreen of "Create doc type":
https://docs.umbraco.com/umbraco-cms/fundamentals/data/defining-content/default-document-types

In the documentation text from the same link is still mentioned as a default document type, so I asume that is a bug...

It is a problem to create more complex pages with the current fresh install because of this... (missing in backoffice structure and consequently in the frontend as a models builder interfaces...)

Steps to reproduce

Settings -> Document Types -> "Create an item under Document Types", ther is no Composition!

Expected result / actual result

Expected result (version 13):
image

Actual resoult:
image

@Borc92 Borc92 added the type/bug label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Hi there @Borc92!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Borc92 Borc92 changed the title [v14.2] Bacckofice - Cant create DocumetnType Composition [v14.2] Bacckofice - Can't create DocumetnType Composition Oct 2, 2024
@Borc92 Borc92 changed the title [v14.2] Bacckofice - Can't create DocumetnType Composition [v14.2] Backoffice - Can't create Document Type Composition Oct 2, 2024
@iOvergaard
Copy link
Contributor

Hello, @Borc92. You are correct in that the documentation is outdated. The procedure is as follows:

  1. Create two document types
  2. Go to the document type that should "inherit" the other
  3. Click "Compositions"
  4. Select the other document type and save that
2024-10-02.at.14.10.36.-.Olive.Skink.mp4

Let me know if that works for you.

@Borc92
Copy link
Author

Borc92 commented Oct 2, 2024

Hi @iOvergaard, thank you for the fast answer!

Well yes you could inherit/composit with the normal DocumentType even before... but I tested it now after you inherit it, models builder creates an interface out of it...
image

I can work with that, thank you!

Just for the knowledge... so basically now the Composition type is removed and we use a normal document type for it?

It would be very useful if changes like this would be written somewhere, especially now that the versions are changing rapidly...

@Borc92 Borc92 closed this as completed Oct 2, 2024
@Borc92 Borc92 reopened this Oct 2, 2024
@iOvergaard
Copy link
Contributor

Yes, I see that there is a difference there. I have submitted a PR to the documentation to describe in more detail how to create compositions. As a rule of thumb, the version-specific (breaking) changes are described in this document on the umbraco docs, but this specific change was not described in any detail there.

I believe the "Composition" option in V13 was not anything special other than a tool to create two document types with an inherent relationship. There never was any special "composition" type to my knowledge at least.

I'm happy if this works for you!

@Borc92
Copy link
Author

Borc92 commented Oct 4, 2024

Hei @iOvergaard

I checked in v13. Yes the Composition element was/is not a special type, it is basicaly an Document type that is Element with a diferent icon... So the same could be said about the doc-type element, you can just create an Document type and flag it optios as "Is Element type"...

My thought is that it was a good implementation for creating a new doc-type specificly for Composition... And maby when porting backofice frontend it accidentally slipped away... :)

image

@iOvergaard
Copy link
Contributor

Yeah, they are all just different configurations of the same thing - different things toggled on and off. We thought the Composition type was a little misused in that it could quickly spam out a lot of document types, that were left unattended. We would rather have that people consciously create the compositional relationships between document types.

There is an active discussion on the subject at #16351, if you'd like to contribute with your thoughts. It contains our reasoning for the choice to leave it out :-)

@marcemarc
Copy link
Contributor

marcemarc commented Oct 7, 2024

I believe the "Composition" option in V13 was not anything special other than a tool to create two document types with an inherent relationship. There never was any special "composition" type to my knowledge at least

@iOvergaard think you are misunderstanding!!, - which might explain why you have accidentally removed this option with out understanding why it was there - there was an option in the'old old menu' to do what you describe - create two related Document Types -, but the composition option here on the menu isn't that! - the introduction of the menu that introduced the composition option removed that confusing two Doc Type option!

Having compositions listed here is mainly to introduce the concept 'before' you create the document type :-P

Previously people 'new to Umbraco' would see the Composition as an option, and think ooh, what's that? ahh, so I can create 'Document Types' to compose other Document Types 'neat' and they are called Compositions, super.

Under the hood a 'Composition' is exactly the same as a 'Document Type' - but that isn't important for people building sites, but knowing about the Composition approach IS, and having a 'word', that describes exactly the thing is soo much easier for discussing site architecture - eg I'm going to create a 'Composition' vs I'm going to create a 'Document Type Without A Template That As Long as it Doesn't itself have other Compositions, can be used as a Composition'

With this change in the new backoffice - people find out about the concept of composition 'after' they have created the Document Type which is too late!- or they must read the documentation first! which then has to be kept updated :-P

Generally it's better to have experiences where people can understand what they need to do from using the system [Citation needed!]

When you've come to redo the backoffice from scratch, and you've tried to rethink things to implement an MVP - I think there the misunderstanding has crept in that because the Composition is implemented in the same way as a Document Type - that this implementation fact was more important for people to learn than the existence of the strategy of compositions!! - Which is true if you are a developer working with the source code and trying to build a new backoffice - but not true if you are a developer new to Umbraco, trying to learn Umbraco from scratch to build a good implementation.

@iOvergaard
Copy link
Contributor

@marcemarc

think you are misunderstanding!!, - which might explain why you have accidentally removed this option with out understanding why it was there - there was an option in the'old old menu' to do what you describe - create two related Document Types -, but the composition option here on the menu isn't that! - the introduction of the menu that introduced the composition option removed that confusing two Doc Type option!

I wonder if you've seen Niels' reply to the discussion you started? It was a conscious choice to omit the option, as he explains:

Point being, the users overview of options is established at this point, and it will deceive them as the Composition will be interpreted as something different than a Document Type. But it is not — Instead I would love that we come up with a solution that underlines that a Composition can be made with anything. Even Element Type can be used as a Composition, Even Document Type with Template can be used as the base for a composition.

I think that the confusion that led to this current issue report is the very thing Niels addresses - people may think it is something special, whereas in fact you can create compositions with just about anything in there.

As Niels goes on to explain, we are not forcefully excluding any kind of supporting UI in this area in the future, but we need to consider what the best approach is:

I do like the intentions and if there is a time where we can move the cheese it is now, which is why we have taken the opportunity to remove it, so there is room later to make a intuitive feature that actually briefs new users on their opportunities

@marcemarc
Copy link
Contributor

Thanks @iOvergaard I have seen it now, thanks, replied there - hopefully I have closure now! Compositions are something special! :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants