Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V15-RC1] TipTap RTE Config Feedback - Disabling an extension does not remove from toolbar #17188

Closed
warrenbuckley opened this issue Oct 4, 2024 · 3 comments

Comments

@warrenbuckley
Copy link
Contributor

warrenbuckley commented Oct 4, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0-RC1

Bug summary

When using the new TipTap editor I have disabled an extension in this case the Underline one, but still have it in the toolbar configuration.

Navigate to a content node with the editor, the Underline button is still in the toolbar and clicking on it does nothing.

Specifics

image

Steps to reproduce

Configure the TipTap RTE editor defaults to disable the Underline extension and keep everything else as is.

Expected result / actual result

I expected the Underline toolbar button to not appear when using the editor inside a content node.


This item has been added to our backlog AB#44725

Copy link

github-actions bot commented Oct 4, 2024

Hi there @warrenbuckley!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

warrenbuckley added a commit to warrenbuckley/HacktoberfestActivityLog that referenced this issue Oct 4, 2024
Link to issue with TipTap testing/feedback
umbraco/Umbraco-CMS#17188
nul800sebastiaan pushed a commit to umbraco/HacktoberfestActivityLog that referenced this issue Oct 4, 2024
Link to issue with TipTap testing/feedback
umbraco/Umbraco-CMS#17188
@iOvergaard
Copy link
Contributor

Yeah, still working on this one. There is currently no other property editor that reacts to changes from one configuration property to another. However, we have some ideas being tossed around how to do it. The 'underline' extension and button belongs together in a 1-1 relationship, however the 'Align' extension has 6 different actions, which may or may not have buttons. This is the issue we currently need to resolve.

Mr. @leekelleher is on the case and we hope to have something either in an upcoming RC or 15.1 depending on how it goes 👍

@iOvergaard iOvergaard added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks state/reproduced area/frontend affected/v15 labels Oct 4, 2024
@warrenbuckley
Copy link
Contributor Author

OK thanks for the update @iOvergaard
Be curious to see/learn how you resolve this with code and UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants