Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels have incorrect generated type #17192

Open
matthewcare opened this issue Oct 4, 2024 · 2 comments
Open

Labels have incorrect generated type #17192

matthewcare opened this issue Oct 4, 2024 · 2 comments
Labels

Comments

@matthewcare
Copy link
Contributor

matthewcare commented Oct 4, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0 to 15.0.0-rc1

Bug summary

Prior to V14 labels would generate with their configured type
i.e Label (integer) with the Value type set to Integer would generate as an int
Since upgrading to V14 all labels are generated as strings

Specifics

No response

Steps to reproduce

Generate models and observe that for an Umbraco default such as Image in the Media Types folder has the properties
umbracoWidth = Label (integer)
umbracoHeight = Label (integer)

Which were previously generated as int, whereas now are generated as string

Expected result / actual result

Expected:
The selected value type is used when generating models

Actual:
All labels are generated as strings regardless of value type


This item has been added to our backlog AB#45486

Copy link

github-actions bot commented Oct 4, 2024

Hi there @matthewcare!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

I was able to reproduce it on v14.3.0 and v15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants