Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to cast IPublishedContent in MediaWithCrops #17204

Closed
matthewcare opened this issue Oct 7, 2024 · 2 comments · Fixed by #17213
Closed

Unable to cast IPublishedContent in MediaWithCrops #17204

matthewcare opened this issue Oct 7, 2024 · 2 comments · Fixed by #17213
Labels

Comments

@matthewcare
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0-rc1

Bug summary

When trying to cast IPublishedContent present in MediaWithCrops to its relevant type you get the exception
InvalidCastException: Unable to cast object of type 'Umbraco.Cms.Infrastructure.HybridCache.PublishedContent' to type 'xyz'.

Specifics

No response

Steps to reproduce

Create a document type with a media with crops allowing Image.
Try to cast the content e.g
Model.MediaWithCrops.Content as Image
Observe that the result is null. Attempting with a hard cast of
(Image)Model.MediaWithCrops.Content results in the exception
InvalidCastException: Unable to cast object of type 'Umbraco.Cms.Infrastructure.HybridCache.PublishedContent' to type 'TheNamespace.Image'.

Expected result / actual result

You should be able to cast the PublishedContent in this case

Copy link

github-actions bot commented Oct 7, 2024

Hi there @matthewcare!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@matthewcare
Copy link
Contributor Author

With a bit more investigation this seems to be true for all content coming from the media cache
Testing with this content in a view

@using Umbraco.Cms.Core.PublishedCache
@using Umbraco.Cms.Infrastructure.HybridCache
@inherits UmbracoViewPage<HomePage>
@inject IPublishedMediaCache mediaCache;
@inject IPublishedContentCache contentCache;

@{
    var media = mediaCache.GetById(1087);
    var content = contentCache.GetById(1096);
}

@(media is Image) @(media.GetType()) <br />
@(content is HomePage) @(content.GetType())

results in

False Umbraco.Cms.Infrastructure.HybridCache.PublishedContent
True Contracts.DocumentTypes.HomePage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant