Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbraco.MediaPicker3] Image Media Picker with crops feature not working - Image URL Issue #17564

Open
XeroDays opened this issue Nov 18, 2024 · 1 comment
Labels

Comments

@XeroDays
Copy link

XeroDays commented Nov 18, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

Umbraco Version 13.4.1

Bug summary

Introduction

So i am using MediaCrops Data type Image Media Picker, where i have added different ratios for different devices such as Mobile, tablet, desktop.. When i am uploading image, i select image for different enviroment.. such as :
image
So here i have three different image aspect ratios, and it generates three different urls for the image.. which are..

Desktop

/media/faibzwdq/sub-persona_student_banner.webp?rxy=0.2537475994987188,0.35341324609398106&width=1140&height=664&v=1db2f9f573e6d6d

Tablet

/media/faibzwdq/sub-persona_student_banner.webp?rxy=0.2537475994987188,0.35341324609398106&width=992&height=600&v=1db2f9f573e6d6d

Mobile

/media/faibzwdq/sub-persona_student_banner.webp?rxy=0.2537475994987188,0.35341324609398106&width=375&height=660&v=1db2f9f573e6d6d

Issue

So i have picked the mobile image url but its still showing as full media image, and its not showing as mobile cropped image as follows

image

Bug

I saw there is extra "amp;" word in the url, and if we remove that then it works fine.
Such as:

image

Resolution

Removing all the amp; from the iamge url will fix it.
image

Specifics

No response

Steps to reproduce

  1. Create data type of image media selector.
  2. add two or three aspect ratios to crop iamge
  3. use the data type in the page
  4. select and upload image
  5. preview both image.

Code

  MediaWithCrops BannerFocused = heroItem.Value<MediaWithCrops>("HeroImage");
  if (BannerFocused != null)
  {
      var desktopImage = BannerFocused.GetCropUrl("desktop") ?? "";
      var tabletImage = BannerFocused.GetCropUrl("tablet") ?? "";
      var mobileImage = BannerFocused.GetCropUrl("mobile") ?? "";
  }

print these urls in page and preview the images.

Expected result / actual result

No response

Copy link

Hi there @XeroDays!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@XeroDays XeroDays changed the title Image Cropper not working properly [Umbraco.MediaPicker3] Image Media Picker with crops feature not working - Image URL Issue Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant