Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better code design for boundary labeling in UW meshing #239

Open
gthyagi opened this issue Aug 29, 2024 · 0 comments
Open

Better code design for boundary labeling in UW meshing #239

gthyagi opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gthyagi
Copy link
Contributor

gthyagi commented Aug 29, 2024

Currently, we can create a UW mesh by calling uw.meshing or by directly passing a DMPlex object or a Gmsh .h5 file to uw.discretisation.Mesh. In the first case, the internally defined boundaries class handles everything and is consistently used throughout the mesh creation process. However, in the second case, we need to manually pass the boundaries to uw.discretisation.Mesh. This can lead to issues if the names and values don't match between the DMPlex/.h5 file and the boundaries class provided. We need a better strategy to address this. Additionally, we must ensure that mesh.dm has boundary labels that are used for applying boundary conditions. This step should be mandatory before solving any set of equations on the mesh.

@gthyagi gthyagi added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant