Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrowed types are Copy so their methods should take self #5921

Open
sffc opened this issue Dec 18, 2024 · 4 comments
Open

Borrowed types are Copy so their methods should take self #5921

sffc opened this issue Dec 18, 2024 · 4 comments
Labels
C-meta Component: Relating to ICU4X as a whole
Milestone
ICU4X 2.0 Stretch...

Comments

@sffc
Copy link
Member

sffc commented Dec 18, 2024

For example, TimeZoneIdMapperWithFastCanonicalizationBorrowed.

Is there a Clippy warning for this? @Manishearth
@sffc sffc added the C-meta Component: Relating to ICU4X as a whole label Dec 18, 2024
@sffc sffc added this to the ICU4X 2.0 Stretch ⟨P2⟩ milestone Dec 18, 2024
@Manishearth
Copy link
Member

Can't find a clippy warning.

@sffc
Copy link
Member Author

sffc commented Dec 19, 2024

If there's no clippy warning, then I think we have no real choice except to make this a best-effort kind of thing.

@sffc
Copy link
Member Author

sffc commented Dec 19, 2024

rust-lang/rust-clippy#12078

@Manishearth
Copy link
Member

Manishearth commented Dec 19, 2024 •
edited
Loading

We should just enable trivially_copy_pass_by_ref. It has a decent threshold set: it warns for types that are of the size usize * 2, which is roughly the threshold where pass by value matters.

We'd need to enable the avoid-breaking-exported-api setting to be allowed to use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-meta Component: Relating to ICU4X as a whole
Projects
None yet
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth