-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handlebars 2.0 required for Ember 1.9.0 #11
Comments
Yes, bootstrap-for-ember has templates compiled by //your-bootstrap-app/Brocfile.js
/* global require, module */
var EmberApp = require('ember-cli/lib/broccoli/ember-app');
var app = new EmberApp({
'ember-cli-bootstrap-sass': {
'components': false
}
});
module.exports = app.toTree(); |
I tried the workaround above but it didn't work. While I can use Bootstrap in my SCSS files, it throws an error As soon as I uninstall ember-cli-bootstrap-sass
|
First step is read this HANDLEBARS VERSION COMPATIBILITY about dependency and how-to In you case maybe need steps:
You are use something like
|
Thanks for the detailed instructions. I'm using ember-cli 1.4. I have already done the steps you described according to the instructions on the Ember blog when upgrading from 1.8 to 1.9. I'm using Handlebars 2.0.0 and I have ditched broccoli-ember-hbs-template-compiler in favor of ember-cli-htmlbars. But the described workaround still didn't have an effect. I don't need the components in bootstrap-for-ember so I have temporarily switched to ember-cli-sass + bootstrap-sass-official from Bower. I couldn't continue work otherwise because of the weird issue with |
Do u think you could put together a small project that we could look at? |
@maxkueng In a similar situation, don't need the components currently but am trying to migrate to ember-cli. Did you get bootstrap and compass setup together? If so, which packages did you use? |
Just got a working setup of bootstrap sass and compass with |
@brandonjmckay I'm now using ember-cli-sass which works but there's another issue with the I'm trying out Materialize now but it has the same problem with ember-cli-sass. Not ideal but it works. |
+1 here.. I'm having same issue with ember-cli-bootstrap-sass & ember 1.9.1 with Handlebars 2.0.0. But setting
helped. |
@maxkueng could you run |
@zekefast I have since switched to ember-cli-sass as I've mentioned in another comment. With my current setup the command you've provided doesn't print anything. If I just grep for "handlebars" in my current setup I get 2.0 everywhere.
|
Is there a plan to fix this? If so, could someone report on the status of the fix? Thanks. |
@maxkueng that means you have no indirect dependencies on |
Ember 1.9.0 which has just been released requires Handlebars = 2.0. However ember-cli-bootstrap-sass ships with templates compiled for Handlebars 1.3.0.
I think what's required is a refresh of bootstrap-for-ember that compiles templates for Handlebars 2.0 and then a refresh of this plugin.
The text was updated successfully, but these errors were encountered: