Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor convert_wildcard_to_* #136

Open
paalbra opened this issue Nov 22, 2020 · 0 comments
Open

Refactor convert_wildcard_to_* #136

paalbra opened this issue Nov 22, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@paalbra
Copy link
Contributor

paalbra commented Nov 22, 2020

It probably makes sense to refactor convert_wildcard_to_filter and convert_wildcard_to_regex after #134 gets resolved.

convert_wildcard_to_filter isn't in use. Maybe just remove it?

convert_wildcard_to_regex might lead to this pattern:

params = {}
param, value = convert_wildcard_to_regex('name', args.name)
params[param] = value

Make input and output a dict probably makes more sense:

params  = convert_wildcard_to_regex({'name': args.name})
@paalbra paalbra added enhancement New feature or request good first issue Good for newcomers labels Nov 22, 2020
oyvindhagberg added a commit that referenced this issue Jun 7, 2023
This commit improves the help texts that describe when you can use
wildcards. It also automatically wraps the parameters in wildcards in
some cases.
Finally, it adds a few commands to the test suite,

Partially takes care of #136.
terjekv pushed a commit that referenced this issue Jun 12, 2023
#167)

* Clarify help about wildcards

This commit improves the help texts that describe when you can use
wildcards. It also automatically wraps the parameters in wildcards in
some cases.
Finally, it adds a few commands to the test suite,

Partially takes care of #136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant