Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #174

Open
5 tasks
haatveit opened this issue Jul 17, 2023 · 0 comments
Open
5 tasks

Fix failing tests #174

haatveit opened this issue Jul 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@haatveit
Copy link
Contributor

While trying to switch from the manual test rigging to using pytest (ae4b1e3) in branch tests-cleanup, this uncovered some issues with the currently burrowed code in previously inaccessible functions that have probably not seen much execution.

We should rewrite or drop the tests if they're outdated, and fix the underlying issues in case any of them are symptoms of bugs/regression.

Fix failing tests

  • Both test_XXX_load and test_ess_migration require postgres but do not currently seem to pass even when a database is present in CI, need more investigation. Running against postgres locally requires a bit of effort from me so I haven't gotten there yet.
    • Maybe test_ess_migration can go either way?
  • test_ZZc_requesting_multiple_ranges_supported failure points to a bug or regression introduced after the test was initially added, as specifying multiple ranges currently leads to weird behavior. We will need to look at how the ranges are parsed.
  • test_ZC_setting_ownership_based_on_user_works does not work with the default configuration of tsd-file-api, will need configuration file or new defaults (probably the test should confirm the require option(s?) is set in the file API).
  • test_X_use_generic_table I've just told pytest to skip for the time being, I think it uses an old endpoint that's not supported anymore?
@haatveit haatveit added the bug Something isn't working label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant