Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to create Ingress that points to 2 different ports in the Service #32

Open
keoren3 opened this issue Feb 21, 2024 · 6 comments
Labels
question Further information is requested

Comments

@keoren3
Copy link

keoren3 commented Feb 21, 2024

I wanted to pass the traces through port 14317 (And 14317 in the backend), while still having the UI available in port 443 (And 14318 in the backend).

I couldn't find any way to do it since the backend-port is attached directly to the HTTP port for the service:
{{- $svcPort := .Values.service.http_port -}}

Am I missing anything?

If I'm not missing anything, I'll create a fix for this (Enable to override the svc port)

@vmihailenco
Copy link
Member

Uptrace has 2 ports: 14317 for OTLP/gRPC and 14318 for OTLP/HTTP & UI. You can change those 2 ports, but you can't have a 3rd port just for the UI.

Does that help?

@keoren3
Copy link
Author

keoren3 commented Feb 21, 2024

I want both ports to be enabled.
So that the Ingress will have 2 backends for the same URL (With different ports) for example:
uptrace.example.com:443 -> uptrace:14318
uptrace.example.com:14317 -> uptrace:14317

Is there a way to do it?

@vmihailenco
Copy link
Member

I guess we're speaking about different things. Let's look at your fix so I can understand better.

uptrace.example.com:443 -> uptrace:14318
uptrace.example.com:14317 -> uptrace:14317

Well, this is just proxying with port re-mapping so it should be possible in principle. But I am not sure if this chart allows that :)

@keoren3
Copy link
Author

keoren3 commented Feb 21, 2024

I'll create a PR ASAP, and we can talk about it

@keoren3
Copy link
Author

keoren3 commented Feb 25, 2024

So I've created a change, but I'm not able to push my branch.
I looked at the contributing guide lines but nothing regarding Git is mentioned there.

@vmihailenco
Copy link
Member

@keoren3 you're supposed to fork the repo and push your branch there: see GitHub documentation.

@vmihailenco vmihailenco added the question Further information is requested label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants