You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently came across pathos as a dependency of another package. Adding pathos forced me to update many packages we already use to the latest version.
I see the dependencies were updated to the latest versions in a sweep here: 33e3f91
Enforcing those latest dependencies in a CI and your requirements.txt file, i.e. the "supported" dependency versions, is probably fine. However, I would argue that forcing these via the setup.py is a bit too strict. What I see in other popular packages is the opposite: "Only update strict minimum version requirements if necessary because of API or bugs"
The text was updated successfully, but these errors were encountered:
I can appreciate what you are saying. In part why the requirements are so strict is that multiprocess is a simple fork of multiprocessing, and it only is guaranteed to be supported against the most recent minor release of python. Thus, whenever the multiprocessing code changes in the STL release, any prior release of multiprocess needs to be updated to the most recent version. Hence, pathos also has strict dependency requirements. I expect that the requirements with dill could be loosened a bit... but multiprocess would fundamentally need to change from being a fork of the current versions of multiprocessing in the current python releases to something that supports multiple recent versions.
Maybe moving the supported versions into requirements.txt is good. They are where they are because the requirements (as noted above) are fairly strict.
I recently came across pathos as a dependency of another package. Adding pathos forced me to update many packages we already use to the latest version.
I see the dependencies were updated to the latest versions in a sweep here:
33e3f91
Enforcing those latest dependencies in a CI and your requirements.txt file, i.e. the "supported" dependency versions, is probably fine. However, I would argue that forcing these via the
setup.py
is a bit too strict. What I see in other popular packages is the opposite: "Only update strict minimum version requirements if necessary because of API or bugs"The text was updated successfully, but these errors were encountered: