Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib for file args to support Windows and Linux. #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use pathlib for file args to support Windows and Linux. #58

wants to merge 1 commit into from

Conversation

ntouran
Copy link

@ntouran ntouran commented Feb 24, 2023

This uses pathlib instead of os.path and enables paths to be either Windows or Linux style.

Fixes #57.

@ntouran ntouran mentioned this pull request Feb 27, 2023
Open
danwos
danwos approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Thanks for the PR. 👍

Only the linter god needs to give his/her okay.

@ntouran
Copy link
Author

ntouran commented Mar 16, 2023

Only the linter god needs to give his/her okay.

Trying to see the issue here. Looks like the linter failed to install its own environment before being able to actually lint?

               raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.

Not sure there's anything I can do about that on my end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwos danwos danwos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update path handling to support Windows paths
2 participants
@ntouran @danwos