Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration validation #3994

Open
zdebel opened this issue Oct 7, 2024 · 14 comments
Open

Registration validation #3994

zdebel opened this issue Oct 7, 2024 · 14 comments
Labels
enhancement New feature or request

Comments

@zdebel
Copy link

zdebel commented Oct 7, 2024

Describe the solution you'd like

It would be great if I could manually accept user registrations. When I have for example SSO turned on, anyone can register and use my memos deployment. I'd like to be able to accept who gets access and who doesn't.

Type of feature

User Experience (UX)

Additional context

No response

@zdebel zdebel added the enhancement New feature or request label Oct 7, 2024
@MehadND
Copy link
Contributor

MehadND commented Oct 12, 2024

So if I understand it correctly you want users to register but restrict their access until you, as the admin, manually review and accept their request and only then they should be given full access.

@zdebel
Copy link
Author

zdebel commented Oct 12, 2024

Yes, exactly. The scenario is I have a memos instance for family and friends, it's easy for them to use Gmail as an auth option, but random people can also register, that doesn't suite me. If I can review who gets in, it makes it great.

@MehadND
Copy link
Contributor

MehadND commented Oct 12, 2024

yeah I never worked on anything like this before but I will try to look into it

@RoccoSmit
Copy link
Contributor

RoccoSmit commented Oct 12, 2024

This seems like a sizable feature, regardless of if it gets built, if you arent expecting too many people to join you could turn on registration in the settings till your family/friends registered and then turn off registrations after. Or you can turn off registration and send out manually created logins

@whiletoken
Copy link

This seems like a sizable feature, regardless of if it gets built, if you arent expecting too many people to join you could turn on registration in the settings till your family/friends registered and then turn off registrations after. Or you can turn off registration and send out manually created logins

but I noticed that the latest version removes the environment variable about public for whether to enable registration or not.

@whiletoken
Copy link

1167df2 Command for public was deleted, So, How to enable or disable registration in the current version

@RoccoSmit
Copy link
Contributor

That removal is from container startup, its a setting now so you can turn it on and off as you require
image

@whiletoken
Copy link

there is no system settting config on my google chrome, system os is debian and macos catalina, but firefox is working fine

@RoccoSmit
Copy link
Contributor

RoccoSmit commented Oct 12, 2024

Only host level users get to see the system menu item in settings. Are you logged in with the same user on all browsers?

@whiletoken
Copy link

image
image

@Issues-translate-bot
Copy link

Issue is not in English. It has been translated automatically.


image
image

@whiletoken
Copy link

image image

the first is google chrome, the second is firefox

@whiletoken
Copy link

google chrome version is 129.0.6668.100

@RoccoSmit
Copy link
Contributor

RoccoSmit commented Oct 13, 2024

Unable to replicate. Do you have any browser extensions in chrome that would remove the content? Or perhaps some customer javascript in your Additional script section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants