Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Impersonate a user #877

Open
alexuco opened this issue Apr 24, 2018 · 7 comments
Open

[Feature Request] Impersonate a user #877

alexuco opened this issue Apr 24, 2018 · 7 comments
Labels
access control Related to the access control feature core feature request Feature request up-for-grabs Not assigned yet
Milestone

Comments

@alexuco
Copy link

alexuco commented Apr 24, 2018

Hi, I know when everything is working fine no matter, but in some cases when as an administrator have to be sure what user can see/reach and feel in her/his profile it give you some additional safety/calmfulness.

In my case, I'm developing some sensitive data and I must be careful on it.
Thanks in advance.

cheers!

@lcharette lcharette added core feature request Feature request access control Related to the access control feature labels Apr 24, 2018
@splitt3r splitt3r changed the title 'impersonate a user' ///// I'm looking for that new feature\\\\\ [Feature Request] Impersonate a user Apr 25, 2018
@frostbitten
Copy link
Contributor

For auditing purposes, if not to just protect your own self from blame if a user turns into a bad actor, it would be good to log/flag impersonated actions with the id of the impersonator.

@Silic0nS0ldier
Copy link
Member

I've been thinking about this for awhile now, and in my opinion the risk here is too great to make it a core feature.

Facebook got caught out with their View As feature (https://krebsonsecurity.com/tag/facebook-view-as-bug/).

It may be that we could make the core secure, but once people extend UF there will be major exploits introduced.

In terms of something more constructive there could be something we can do to make user impersonation easier to manually implement. Be it via a special sprinkle and/or core enhancements.

@lcharette
Copy link
Member

If we are talking about permission impersonating, to debug a specific user permission, I don't see the issue since the master user has permission to do (and see) everything already.

Seeing record associated with a particular user_id, and worst, doing action on behalf of this ID, then that's a problem, yes.

@Silic0nS0ldier
Copy link
Member

Its more the potential side effects I'm worried about. One-demand permission impersonation isn't a problem provided its done clearly and intentionally (talking backend here, full permission check method already allows a user object to be passed from memory), however to address what is requested a blanket solution would be required (so that the master user 'is' the specified user for a time).

@amosfolz
Copy link
Contributor

I agree and administrators should never have the ability to impersonate a user (for the protection of the user and administrator). One can easily create a test user and assign it the appropriate permissions if they want to log on and actually see what the end-user will see.

What I think may be beneficial is a Permission Audit feature (I'm thinking along the lines of Microsoft Effective Access.) This could be something like selecting a user and then a specific URI/route and getting checking the response...

@fembuelita
Copy link

Another idea may be to copy a user's permission set from User A to user B, (or clone User A as new User B) provided neither user is the super admin. This would make it easier to verify permissions/roles/etc without impersonating a user.

@lcharette lcharette added the up-for-grabs Not assigned yet label Jun 27, 2019
@amosfolz
Copy link
Contributor

amosfolz commented Jul 8, 2019

Another idea may be to copy a user's permission set from User A to user B, (or clone User A as new User B) provided neither user is the super admin. This would make it easier to verify permissions/roles/etc without impersonating a user.

I could see a feature like that being useful.

There have been a number of concerns/opinions expressed. We need to land on a decision as to if this is something to add or not.

@lcharette lcharette added this to the 5.1.0 milestone Nov 25, 2023
@lcharette lcharette moved this to Todo 5.1.0 in UserFrosting Task Planner Nov 26, 2023
@lcharette lcharette moved this from Todo 5.1.0 to Todo 5.2.0 in UserFrosting Task Planner Feb 10, 2024
@lcharette lcharette modified the milestones: 5.1.0, 5.2.0 Feb 17, 2024
@lcharette lcharette moved this from Todo 5.2.0 to Not Started in UserFrosting Task Planner Apr 13, 2024
@lcharette lcharette modified the milestones: 5.2.0, 5.3.0 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access control Related to the access control feature core feature request Feature request up-for-grabs Not assigned yet
Projects
Status: Not Started
Development

No branches or pull requests

6 participants