New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stencil Buffer test not used to cull light volume fragments which do not contain scene geometry within them. #2

Open

devshgraphicsprogramming opened this issue May 21, 2018 · 0 comments

devshgraphicsprogramming commented May 21, 2018

Even the Z discard is commented out
https://github.com/osense/irrRenderer/blob/master/bin/shaders/light_point.frag#L25

Stencil tests+Z tests will enable discarding of unshadeable pixels directly in hardware before reading from a Z-texture

Some details of deferred implementations for anyone who'd want to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment