Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission] Do not display contact email address when empty. #4866

Closed
nimishmedatwal opened this issue Mar 24, 2024 · 0 comments
Labels

Comments

@nimishmedatwal
Copy link

Problem with accordance to accessibility guidelines:

  • The element lacks visible text that screen readers can interpret, thereby hindering accessibility for visually impaired users.
  • It is included in the tab order but lacks accessible text, which means keyboard users may not understand its purpose or function.
  • Empty tag, providing no meaningful content or interaction for users.
 <a _ngcontent-cll-c66="" class="company-info__email" href="mailto:" data-qa="contact-email"></a> 

Proposed solution

  • Do not display `contact email address when it's empty.
    When empty
    image
    When not empty
    image

  • Accessibility Attributes: Ensure that the tag has appropriate accessibility attributes to make it accessible to users of assistive technologies, such as screen readers. This includes adding aria-label or title attributes to provide additional context for the link.

Additional context
image

@linear linear bot added the Migrated label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants