Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[/assessment-plan/local-definitions[1]/objectives-and-methods[1]/part[2]/prop[1]/@name] Value 'method' doesn't match one of 'alt-identifier, label, marking, or sort-id' at path '/assessment-plan/local-definitions[1]/objectives-and-methods[1]/part[2]/prop[1]/@name' #277

Open
Telos-sa opened this issue Aug 23, 2024 · 4 comments
Labels
question The issue contains a question that needs to be answered.

Comments

@Telos-sa
Copy link

Validation error seems to conflict with cardinality rules for assessment-method. Located in Local Definitions.

What was validated

 "local-definitions":{
            "objectives-and-methods":[
               {
                            "name":"assessment-objective",
                            "ns":"http://csrc.nist.gov/ns/oscal",
                            "props": [
                                {
                                    "name": "method-id",
                                    "ns":"http://csrc.nist.gov/ns/oscal",
                                    "value":"Examine databases"
                                }
                            ]
                        },
                        {
                            "name":"assessment-method",
                            "ns":"http://csrc.nist.gov/ns/oscal",
                            "props":[
                                {
                                    **"name":"method",**
                                    "uuid":"df1c6b21-679c-57f0-b0e1-c6b6a4f05bad",
                                    "ns":"http://csrc.nist.gov/ns/oscal",
                                    "value":"EXAMINE"
                                }
                            ]
                        }
                    ]
                },

Cardinality rules from Model seems to indicate the structure is correct.
image

Can you please provide guidance in determining our error:

@Telos-sa Telos-sa added the question The issue contains a question that needs to be answered. label Aug 23, 2024
@Telos-sa
Copy link
Author

When testing without the prop, get a cardinality issue. Cannot identify the structure discrepancy
sap_val.txt
sap_val2.txt
to determine how to proceed.

@iMichaela
Copy link
Contributor

iMichaela commented Aug 23, 2024

@Telos-sa - Thank you for pointing to this bug. I noticed it too and I raised it in the Data bites (FedRAMP) meeting so we fix it in a way that aligns with the community's expectations, FedRAMP in particular.

Do you mind moving the issue to the correct repo? Alternatively, I can move it, and close it here.

@Telos-sa
Copy link
Author

@iMichaela If you could move it, that would be helpful, and drop us a line as to where we should place these. We are starting to ramp up on the FedRAMP validation pilot, so there will be elements coming through from all of the models.

Let me know what the best practice should be for this, so we can sort these issues appropriately.

@iMichaela
Copy link
Contributor

@iMichaela If you could move it, that would be helpful, and drop us a line as to where we should place these. We are starting to ramp up on the FedRAMP validation pilot, so there will be elements coming through from all of the models.

Let me know what the best practice should be for this, so we can sort these issues appropriately.

Hi Lacy - those are all OSCAL schema issues and the OSCAL repo is the place for this kind of bugs. In this repo we only keep the artifacts in OSCAL. Wishing you and Telos team the best of luck with the pilot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question The issue contains a question that needs to be answered.
Projects
Status: Needs Triage
Development

No branches or pull requests

2 participants