Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffle vs. python 3.11 #11

Open
bennn opened this issue Nov 8, 2023 · 2 comments · May be fixed by #12
Open

shuffle vs. python 3.11 #11

bennn opened this issue Nov 8, 2023 · 2 comments · May be fixed by #12

Comments

@bennn
Copy link
Member

bennn commented Nov 8, 2023

Python 3.11 removed the 2nd argument to shuffle.

Argh.

Rewrite any shuffles we have to seed the RNG so shuffle(x) gives the same result as shuffle(x, fn)
@Vishalk91-4 Vishalk91-4 linked a pull request Jan 24, 2024 that will close this issue
Open
@mrigankpawagi
Copy link
Contributor

Hi, why was this an issue by the way? Cinder is currently on 3.10.

@bennn
Copy link
Member Author

bennn commented Jun 2, 2024

I think Vivaan and I got started on benchmarks without using Cinder, just the latest Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved Shuffle to python 3.11 Vishalk91-4/static-python-perf
2 participants
@bennn @mrigankpawagi