Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/ref/runtime/internal/flow: flow control counters grow without bound #285

Open
cosnicolaou opened this issue Aug 24, 2022 · 0 comments
Open

x/ref/runtime/internal/flow: flow control counters grow without bound #285

cosnicolaou opened this issue Aug 24, 2022 · 0 comments

Comments

@cosnicolaou
Copy link
Contributor

The map used to keep track of per-flow flow control counters/tokens can grow without bound since the map entries are not deleted when a flow is closed.
@cosnicolaou cosnicolaou mentioned this issue Aug 24, 2022
Open
@cosnicolaou cosnicolaou transferred this issue from vanadium/issues Aug 24, 2022
@cosnicolaou cosnicolaou mentioned this issue Aug 24, 2022
Merged
cosnicolaou added a commit that referenced this issue Aug 24, 2022
@cosnicolaou
x/ref/runtime/internal/flow: delete flow control counters when a flow…
f2f0f5e 
… is closed #287

This PR addresses #285 by deleting the per-flow flow control counters maintained by the underlying connection when a flow is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cosnicolaou