Delete Scale UI #528
Open
Delete Scale UI #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 2486672 into 1a55132 - view on LGTM.com new alerts:
|
|
FYI in guidesReducer.ts, guideReducer deletes guides when scales are deleted. |
|
This pull request introduces 1 alert when merging 3637882 into 1a55132 - view on LGTM.com new alerts:
|
jonathanzong
reviewed
Dec 3, 2020
| @@ -109,7 +143,12 @@ class ScaleList extends React.Component<StateProps & DispatchProps> { | |||
| data-scale={scale.get('_id')} | |||
| data-field={field}> | |||
| {/* <ContentEditable value={name} save={updateScaleName} /> */} | |||
| {name} | |||
| <div style={{ "marginLeft": "26px" }}> | |||
There was a problem hiding this comment.
let's try to avoid inline styles if possible. can we put this in the stylesheet?
|
this looks good! requested behaviors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding UI for deleting scales.