fix: preserve gradientLength when generating discrete gradient color legend #9400
+173
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid dropping gradientLength
hydrosquall
force-pushed
the
cameron.yick/check-vega-lite-compile-spec-discrete-legend
branch
from
c6fd282
to
c158c80
Compare
Deploying vega-lite with
|
| Latest commit: |
79784bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8cf42480.vega-lite.pages.dev |
| Branch Preview URL: | https://cameron-yick-check-vega-lite.vega-lite.pages.dev |
hydrosquall
changed the title
hydrosquall
changed the title
hydrosquall
commented
Jul 31, 2024
| (legendType === 'gradient' && property.startsWith('symbol')) || | ||
| (legendType === 'discrete' && property.startsWith('symbol')) || |
There was a problem hiding this comment.
Before I add any tests or open PRs in vega, I want to check if this is the behavior (a third legendType called discrete) we want as a public API, or if this was supposed to be a private/internal API.
The discrete legend type was added by @jheer in vega/vega@ddd2bbf , so I'll bring it up as a separate issue in the vega repo vega/vega#3954 .
…erty at compile time
hydrosquall
force-pushed
the
cameron.yick/check-vega-lite-compile-spec-discrete-legend
branch
from
9fe4a63
to
f13f69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
quantileandquantizecolor scales #9399Testing
gradientLengthproperty should be respected for a color legend that uses quantile, quantize, or threshold scales.300, and the legend should get taller.{ "$schema": "https://vega.github.io/schema/vega-lite/v5.json", "data": {"url": "data/cars.json"}, "mark": "rect", "encoding": { "y": {"field": "Origin", "type": "nominal"}, "x": {"field": "Cylinders", "type": "ordinal"}, "color": { "aggregate": "mean", "field": "Horsepower", "scale": {"type": "quantile"}, "legend": {"gradientLength": 30} } }, "config": {"axis": {"grid": true, "tickBand": "extent"}} }Notes
vega-liteso this PR can be reviewed. However, we could make the diff in this repo smaller if we instead push a change to theLegendTypefield inside ofvegainstead.