Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null and empty string categories correct stacking behaviour #3992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: null and empty string categories correct stacking behaviour #3992

wants to merge 1 commit into from

Conversation

MarcBaeuerle
Copy link

PR description

closes vega/vega-lite#9428

map[[null]] and map[[""]] are equivalent which caused the grouping calculation to get messed up. Added JSON.stringify to differentiate the two.

Screenshot 2024-12-10 at 01 46 11

Checklist
  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully

@MarcBaeuerle MarcBaeuerle requested a review from a team as a code owner December 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar charts with null and empty string categories produces odd results
1 participant
@MarcBaeuerle