Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: axis "description" not overriding default aria-label #3991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: axis "description" not overriding default aria-label #3991

wants to merge 1 commit into from

Conversation

MarcBaeuerle
Copy link

PR description

closes vega/vega-lite#9432

Issue rose because mark.items[0] didn't contain the description that was provided, so it defaulted to the aria attribute generators. The description was present in mark.description instead.

Checklist
  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully

@MarcBaeuerle MarcBaeuerle requested a review from a team as a code owner December 9, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axis "description" is not overriding default aria-label
1 participant
@MarcBaeuerle