Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Left-align field name in tooltips #689

Open
fandu-db opened this issue Aug 12, 2022 · 5 comments
Open

[Tooltip] Left-align field name in tooltips #689

fandu-db opened this issue Aug 12, 2022 · 5 comments

Comments

@fandu-db
Copy link

A very subjective proposal -- it appears to me that "left-aligned field name" in tooltip looks slightly better and is also more commonly seen in visualization tools (e.g., Tableau).

image

@domoritz
Copy link
Member

domoritz commented Aug 12, 2022

Thanks for the feedback. I find it easier to read what values correspond to each other especially when the labels get long. Luckily, this can easily be changed in CSS. Unless there are strong reasons to change this, I think I'd just leave it.

@kanitw
Copy link
Member

kanitw commented Aug 16, 2022

I actually strongly prefer Fan's proposed design because readers can scan and read the field names faster if they are left aligned.

Plus if we add legend for color in a follow up PR, the symbols will be aligned if we do left aligned. (But they won't if we keep right alignment.)

@domoritz
Copy link
Member

I see. I am okay with changing the design. We should limit the width of the field name column so that it doesn't become to difficult to make the correspondance to the values. Do you want to send a pull request?

@fandu-db
Copy link
Author

Many thanks @domoritz @kanitw for supporting this! Yes, we will send a PR.

Great point on "limit the width of the field name column"
For handling long field names, we can probably try line wrap and/or truncation (w/ ...)
Wonder if you have a preference or other ideas

@domoritz
Copy link
Member

I'd prefer wrap and if we truncate definitely add a tooltip to see the full text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants