Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance participants on games API to be more granular #11008

Open
JonRay15 opened this issue Mar 26, 2024 · 1 comment
Open

Enhance participants on games API to be more granular #11008

JonRay15 opened this issue Mar 26, 2024 · 1 comment
Labels
api enhancement New feature or request fe-request A list of reasonably high value API change requests from front end team

Comments

@JonRay15
Copy link

Issue

Look at https://darling.network/api/v2/games

For "participants" we are just showing a single number which appears to be the number of actual keys paid in a game ... this is not right for a few reasons.

To make this clearer I think we should show multiple things here and then we can choose which to use in the appropriate case.

Proposal

Show

  1. Number of paid entities - where entity is set by the entity scope, ie. if it is a team game show the number of participating teams, if its a individual game the number of participating individuals
  2. Number of paid keys - ie. in a team game this would count the actual paid players in those teams, in individual game it would be unchanged
  3. Number of eligible entities - currently we are ONLY showing paid entities, which is misleading because there are various teams which are "playing" and meeting the eligibility criteria but have performed poorly and therefore not been rewarded. Ideally we would show all entities which have met the criteria as "participating"
  4. Number of participant keys - so this would be the same as above but for every key single key
@gordsport gordsport moved this to Todo in Core Kanban Mar 26, 2024
@gordsport gordsport added this to the 🏛️ Colosseo milestone Mar 26, 2024
@gordsport gordsport added api team enhancement New feature or request labels Mar 26, 2024
@JonRay15 JonRay15 added the fe-request A list of reasonably high value API change requests from front end label Apr 15, 2024
@JonRay15
Copy link
Author

I cant really recall what this is ... so it cant be that important ... happy to move it to Genbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request fe-request A list of reasonably high value API change requests from front end team
Projects
Status: Todo
Development

No branches or pull requests

2 participants