Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Validation #19

Open
BenjamenMeyer opened this issue Nov 3, 2020 · 3 comments
Open

Version Validation #19

BenjamenMeyer opened this issue Nov 3, 2020 · 3 comments

Comments

@BenjamenMeyer
Copy link
Member

BenjamenMeyer commented Nov 3, 2020

How do we make sure the Release Version is the correctly specified?

Continuation of discussion from vegastrike/Assets-Production#38

@BenjamenMeyer
Copy link
Member Author

Some discussed options:

  • strict release names and CI/CD integration
  • validation step in the release process
  • unit test validation to see that things match up

We should at least do the validation step during the release processes while we figure this out; that will satisfy requirements for 0.7.x release if we don't have something by then.

NOTE: This is presently marked against the next release (0.7.x) just to keep it at the top of our priorities. It can slip to 0.8.x or 0.9.x if need be.

@stephengtuggy
Copy link

We have come a long ways with regard to versioning in the last few months. With the 0.8.x release series, we should be able to ensure that the desired version -- including git commit SHA -- is automatically included, correctly, in the installer filenames, installer versions, and code for both the Game Engine and the Assets.

As a next step, I'm thinking maybe we do away with hard-coded version numbers altogether, and just have the relevant parts of the game (like the Introduction and Credits screens) pull the version in code, of the engine and of the game assets, and dynamically display those. How does that sound to you guys?

@BenjamenMeyer
Copy link
Member Author

Agreed. We're close to being able to have a single point of version definition. The engine should be really close; most of the work probably needs to be done on the Asset side, but now that the Engine exposes a version to the assets that can be done - we just have to require that the Engine API Version is 1 or greater to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants