Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tar ball missing programs #29

Closed
susnux opened this issue May 8, 2021 · 13 comments
Closed

Release tar ball missing programs #29

susnux opened this issue May 8, 2021 · 13 comments

Comments

@susnux
Copy link

susnux commented May 8, 2021

Describe the bug
The programs directory is missing in the tar.xz release tar ball.
( vsUTCS_v0.7.0-Source.tar.xz )

@BenjamenMeyer
Copy link
Member

@susnux please be more specific in your bug. Are you looking for the generated binaries to also be provided?

@BenjamenMeyer
Copy link
Member

Looking closer...https://github.com/vegastrike/Assets-Production/blob/master/CMakeLists.txt#L66 should make it be included, though I can see with tar -Jtx that programs isn't in there. Not sure why...probably due to the types of files in there.

@susnux
Copy link
Author

susnux commented May 11, 2021

@susnux please be more specific in your bug. Are you looking for the generated binaries to also be provided?

Yes, sorry.
The tar.xz tar ball provided on GitHub (releases) does not contain the programs directory, so building will fail as CMake can not find that directory.

@Loki1950
Copy link
Member

What do you mean by a programs directory I have been with this project for over ten years there has never been a directory called programs there is one called /bin where the executable and .dll's on windows are placed.

@BenjamenMeyer
Copy link
Member

BenjamenMeyer commented May 11, 2021

@Loki1950 https://github.com/vegastrike/Assets-Production/tree/master/programs
Probably need to call it shaders instead.

@Loki1950
Copy link
Member

Ah that one forget why klauss called it programs so yes shaders would more descriptive.

@stephengtuggy stephengtuggy self-assigned this May 31, 2021
@stephengtuggy
Copy link

I would like to see this get fixed in 0.7.x, as well as in 0.8.x and on master. I don't think it will be too difficult a fix. In fact, I'll take a look at it right now.

@BenjamenMeyer
Copy link
Member

@stephengtuggy for 0.7.x leave it as programs; for 0.8.x or 0.9.x we'll rename it to shaders.

@stephengtuggy
Copy link

@BenjamenMeyer Sounds good.

@stephengtuggy
Copy link

@susnux could you verify whether or not this problem is fixed as of https://github.com/vegastrike/Assets-Production/releases/tag/v0.7.1-beta1 ?

@BenjamenMeyer
Copy link
Member

Added #31 to track the rename separately. This can be closed out once someone (preferably @susnux ) confirms that the latest releases fix this.

@pyramid3d
Copy link

As far as I recall, the programs directory was introduced by former contributor klauss during his planetary shader improvements stanza. https://github.com/vegastrike/Assets-Production/tree/master/programs seems to contain the shader programs but I do not have any insight as to how those tie into the code as those changes happened during my hiatus from the project. If you really need to track it back the old svn repo should still have the history available.

@susnux
Copy link
Author

susnux commented Jul 9, 2021

@susnux could you verify whether or not this problem is fixed as of https://github.com/vegastrike/Assets-Production/releases/tag/v0.7.1-beta1 ?

It works as expected 👍

@susnux susnux closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants