-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tar ball missing programs #29
Comments
@susnux please be more specific in your bug. Are you looking for the generated binaries to also be provided? |
Looking closer...https://github.com/vegastrike/Assets-Production/blob/master/CMakeLists.txt#L66 should make it be included, though I can see with |
Yes, sorry. |
What do you mean by a programs directory I have been with this project for over ten years there has never been a directory called programs there is one called /bin where the executable and .dll's on windows are placed. |
@Loki1950 https://github.com/vegastrike/Assets-Production/tree/master/programs |
Ah that one forget why klauss called it programs so yes shaders would more descriptive. |
I would like to see this get fixed in 0.7.x, as well as in 0.8.x and on master. I don't think it will be too difficult a fix. In fact, I'll take a look at it right now. |
@stephengtuggy for 0.7.x leave it as |
@BenjamenMeyer Sounds good. |
@susnux could you verify whether or not this problem is fixed as of https://github.com/vegastrike/Assets-Production/releases/tag/v0.7.1-beta1 ? |
As far as I recall, the programs directory was introduced by former contributor klauss during his planetary shader improvements stanza. https://github.com/vegastrike/Assets-Production/tree/master/programs seems to contain the shader programs but I do not have any insight as to how those tie into the code as those changes happened during my hiatus from the project. If you really need to track it back the old svn repo should still have the history available. |
It works as expected 👍 |
Describe the bug
The programs directory is missing in the tar.xz release tar ball.
(
vsUTCS_v0.7.0-Source.tar.xz
)The text was updated successfully, but these errors were encountered: