Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site picker and status list shows sites that the navigation is not enabled for #407

Open
MoritzLost opened this issue Oct 10, 2024 · 1 comment

Comments

@MoritzLost
Copy link

Describe the bug

We have a navigation that is only enabled for some sites, but disabled for others:

site-settings

But in the author UI for that navigation, the sites dropdown shows all sites, even the sites that the navigation is not enabled for:

site-dropdown

But switching to a site that the navigation is disabled for results in a 404 error:

HTTP 404 – Not Found – yii\web\NotFoundHttpException
Navigation not enabled for site: site_a

It would be better to only show sites that the navigation is enabled for in the dropdown, similar to entry form pages.

When editing a single node, the status in the sidebar also shows all sites:

Screenshot 2024-10-10 at 14 57 54

But the element isn't even propaged to Site A in this case, so this again should only show Site B and Site C.

Steps to reproduce

  1. Create multiple sites
  2. Create a navigation that's only enabled for some sites
  3. Go to the navigation edit page and check the dropdown, as well as the status for a single node

Craft CMS version

5.4.5.1

Plugin version

3.0.4

Multi-site?

Yes

Additional context

No response

@engram-design
Copy link
Member

Fixed for the next release. To get this early, run composer require verbb/navigation:"dev-craft-5 as 3.0.4".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants