Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto-pouch library #21

Closed
5 tasks
benlongstaff opened this issue Aug 30, 2021 · 1 comment · Fixed by #34
Closed
5 tasks

Update crypto-pouch library #21

benlongstaff opened this issue Aug 30, 2021 · 1 comment · Fixed by #34
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benlongstaff
Copy link

Update from using https://github.com/tahpot/crypto-pouch.git to the latest version of crypto-pouch (v4.0.1) this will remove some vulnerabilities in the elliptic package calvinmetcalf/crypto-pouch#76 that is currently being used.

Repositories requiring the change

package.json

yarn.lock

@tahpot
Copy link
Member

tahpot commented Aug 31, 2021

I'll only update in the new library verida/packages/client-ts. Any changes will be merged into verida/client-rn.

Submitted a PR to allow initialising crypt-pouch with a user specified salt:
calvinmetcalf/crypto-pouch#80

I have created a feature branch to support this change (https://github.com/verida/verida-js/tree/feature/21-update-crypto-pouch). Tested and works locally as expected. Won't merge into main until the crypto-pouch PR is merged. We can optionally use the feature branch created in the forked repo if the PR isn't accepted in time (https://github.com/tahpot/crypto-pouch/tree/feature/support-key-import).

Updated task list:

@tahpot tahpot self-assigned this Aug 31, 2021
@tahpot tahpot added the enhancement New feature or request label Aug 31, 2021
@tahpot tahpot added this to the MVP Release milestone Aug 31, 2021
@tahpot tahpot closed this as completed in #34 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants