Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogiri License is not recognized but it still includes valid License.txt #11

Open
stefan-kolb opened this issue Nov 4, 2016 · 1 comment

Comments

@stefan-kolb
Copy link

stefan-kolb commented Nov 4, 2016

License file: https://github.com/sparklemotion/nokogiri/blob/master/LICENSE.txt
Somehow the algorithm has problems with the file contents.

Caused by line breaks possibly:

to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,

https://github.com/versioneye/crawl_r/blob/master/lib/versioneye/crawlers/license_crawler.rb, line 370

The matcher should be made more robust to line breaks.

@timgluz
Copy link
Contributor

timgluz commented Jan 9, 2017

@reiz This issue should go away when you switch to LicenseMatcher as it uses wordvectors and cos-similarity to calculate best match und it supports all the SPDX licenses + custom licenses;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants