Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TTML) Add an optional way to separate speakers by style #29

Open
vevv opened this issue Aug 25, 2024 · 0 comments
Open

(TTML) Add an optional way to separate speakers by style #29

vevv opened this issue Aug 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@vevv
Copy link
Owner

vevv commented Aug 25, 2024

Some subtitles use different styles for different speakers, those could be converted to dashes.

<p begin="00:02:04.120" end="00:02:07.640" region="agr_0.5_20_39.5_4_after" style="S2" xml:id="C30_1">
  <span style="S3">Someone get that, will you?</span>
  <br/>
  <span style="S4">Liam's turn.</span>
</p>

<p begin="00:07:32.280" end="00:07:35.160" region="agr_0.5_20_39.5_4_after" style="S2" xml:id="C125_1">
  <span style="S5">Are you gonna do it again before</span>
  <br/>
  <span style="S5">school?</span>
  <span style="S3">Give him a break,</span>
</p>

The fix for hanging single-words will have to take dashes into account, as currently it processes the second example as:

122
00:07:32,280 --> 00:07:35,160
Are you gonna do it again before
school? Give him a break,

Where the ideal probably is:

122
00:07:32,280 --> 00:07:35,160
- Are you gonna do it again before school?
- Give him a break,

Unfortunately this is still not ideal, but probably the best that can be done in SRT, as those are originally positional subs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant