Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to detect "com.microsoft.playready.recommendation" key system #167

Open
rtkac opened this issue Jul 19, 2022 · 6 comments
Open

Request to detect "com.microsoft.playready.recommendation" key system #167

rtkac opened this issue Jul 19, 2022 · 6 comments

Comments

@rtkac
Copy link

rtkac commented Jul 19, 2022

Hi,

there is a key system com.microsoft.playready.recommendation recommended by Edge.
Is there any planned support?

Or do you have any information?

Thanks! :)

@gkatsev
Copy link
Member

gkatsev commented Jul 20, 2022

Sounds like something that should be added. Unfortunately, I don't think anyone on the team likely has the bandwidth to tackle it currently.

shaka-project/shaka-player#1495 had an interesting discussion on potentially using this if available even if users use com.microsoft.playready. Though, seems like it doesn't do it by default, but there's a config for it (keySystemsMapping)

@benesva4
Copy link

benesva4 commented Aug 18, 2022

Hey, @gkatsev.

I'd like to make a PR to enable com.microsoft.playready.recommendation in videojs-contrib-eme. I came up with two possible ways this could be implemented.

The first and easier way would be to simply add support for recognition of the .recommendation keysystem to the existing conditions for playready. Since the keysystem behaves almost identically essentially the playready conditions would change to recognize both playready + playready.recommendation. Function getSupportedKeySystem is then dependant on the name of the key system so there shouldn't be any changes needed there.

The other possibility would be making some kind of smarter logic that would try to use the .recommendation automatically even if it's not specified in the config options of the player. E.g. the player is configured with vanilla playready and the contrib-eme would try to use the .recommendation playready version first and would fallback to vanilla playready afterwards if the .recommendation is not usable/supported by the os/browser. From what I've seen, this is the way they implemented the recommendation playready version in the shaka player.

@benesva4
Copy link

I opened PR with the simple solution.
#171

@BucherTomas
Copy link

As per https://learn.microsoft.com/en-us/playready/overview/key-system-strings#available-key-system-strings , this is becoming a hot topic, because Microsoft is seemingly planning to get rid of legacy com.microsoft.playready completely in Edge browser and just com.microsoft.playready.recommendation and com.microsoft.playready.recommendation.3000 will remain.

This means that videojs-based players might very likely stop working in Edge with PlayReady content unless these key systems are supported.

The urgency for this task is therefore unfortunately increasing.

@misteroneill
Copy link
Member

Yep, this is on the radar.

@BucherTomas
Copy link

@misteroneill Can you please guess when you might find the time for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants