Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the performance of multiple delete operations in a transaction #256

Open
1 task
vincent-herlemont opened this issue Oct 12, 2024 · 1 comment
Open
1 task
Labels
help wanted Open issue for anyone who wants to work on it. performance Performance improvement or benchmarking issue

Comments

@vincent-herlemont
Copy link
Owner

During the PR #254 that added benchmarks, I realized there was a performance issue concerning the delete operation when there are many within a single transaction.

TODO

  • Investigate
@vincent-herlemont vincent-herlemont added help wanted Open issue for anyone who wants to work on it. performance Performance improvement or benchmarking issue labels Oct 12, 2024
vincent-herlemont added a commit that referenced this issue Oct 12, 2024
@vincent-herlemont
Copy link
Owner Author

It is possible that this operation binary_value.inner() is unnecessary because we could return T directly in case of success, which would avoid this unnecessary operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open issue for anyone who wants to work on it. performance Performance improvement or benchmarking issue
Projects
None yet
Development

No branches or pull requests

1 participant