Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user preferences out of main config #2071

Open
vkbo opened this issue Oct 27, 2024 · 0 comments
Open

Move user preferences out of main config #2071

vkbo opened this issue Oct 27, 2024 · 0 comments
Labels
planned Note: Feature planned for a later release refactoring Request: Code refactoring needed user interface Component: General user interface

Comments

@vkbo
Copy link
Owner

vkbo commented Oct 27, 2024

This is a structural/refactoring task.

The user preferences are currently stored in the main config file, and mixed in with system state settings. Instead, it may be useful to store them in a way similar to how Manuscript Build settings are stored. They have a dictionary describing their data type and default value, a mirror dictionary with all the translation strings, and standard getter and setter functions.

The CONFIG object can still read and populate from this object at startup, but the point here is to centralise the preference so that:

  • The GUI label of all Preferences are kept in once place, reducing duplicate translations.
  • There is a record of the default value, allowing a reset to default, as requested in Restoring default preferences #1080.
  • It is possible to select settings for Project override quite easily, and a standard way of generating the override files through the same data object.
@vkbo vkbo added user interface Component: General user interface refactoring Request: Code refactoring needed planned Note: Feature planned for a later release labels Oct 27, 2024
@vkbo vkbo added this to the Release 2.7 Beta 1 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planned Note: Feature planned for a later release refactoring Request: Code refactoring needed user interface Component: General user interface
Projects
None yet
Development

No branches or pull requests

1 participant