Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate all Lobotomy Corp files from random locations in the code to a collective Lobotomy Corp 13 folder. #1609

Open
InsightfulParasite opened this issue Nov 6, 2023 · 8 comments
Labels
Code improvement Code is now easier to copy paste.

Comments

@InsightfulParasite
Copy link
Collaborator

This is more a reminder than a feature request since we are extremely sloppy with how we place our code and icons. However doing this now would cause a large upheaval of most of the code we currently have. So we have to wait until a feature freeze occurs.

@InsightfulParasite InsightfulParasite added the Code improvement Code is now easier to copy paste. label Nov 6, 2023
@Gboster-0
Copy link
Collaborator

This definetelly would be very helpfull
but getting abnormalities modularized definetelly needs to convince egor, as right now they are a bit against abnormality modularization

@EgorDinamit
Copy link
Member

Modularization's only purpose is to help with active downstream coding, which we are not participating in (i.e. we don't ever pull from upstream).
As such - the only thing that needs to be "improved" here, is to make sure everything is in an easily accessible place.

Icons have to be placed under one folder for ease of access, but code files are already "modularized" well and there's nothing else to do with it.

@Gboster-0
Copy link
Collaborator

Gboster-0 commented Nov 15, 2023

Not really... our code is frankly shit in terms of code modularization

@EgorDinamit
Copy link
Member

That's because we do not need "modularization" in the first place.

@InsightfulParasite
Copy link
Collaborator Author

InsightfulParasite commented Nov 15, 2023

I kinda want it because then our content can be easily imported and exported by anyone who wants it.
If anyone wants to modularize the code i will support their efforts in doing that.
Honestly we might just repurpose the TeguModularization folder since we havent gotten many updates from them recently.

@EgorDinamit
Copy link
Member

The modular folder should be removed entirely.

@Gboster-0
Copy link
Collaborator

The modular folder should be removed entirely.

that would eighter remove a lot of content that admins can make, or dirty the hell out of our fork (thats already quite dirty)

@EgorDinamit
Copy link
Member

The modular folder is what makes our repository "dirty" to begin with. All things should be well organized in one place, not thrown all over the place in random folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste.
Projects
None yet
Development

No branches or pull requests

4 participants