Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tls configuration configurable via flags #1023

Open
cirocosta opened this issue Sep 19, 2022 · 3 comments
Open

make tls configuration configurable via flags #1023

cirocosta opened this issue Sep 19, 2022 · 3 comments
Milestone

Comments

@cirocosta
Copy link
Contributor

cirocosta commented Sep 19, 2022

Description of problem

We've seen cases where folks need to have a couple properties

  • CipherSuites
  • TLSMinVersion
  • others? (cc @xyloman)

Proposed solution

have a set of flags for the properties that we want to customize such that in the Kubernetes Deployment object we're able to customize it if necessary, e.g.

kind: Deployment
...
     args:
         --tls-min-version=...

Acceptance criteria

  • package-for-cartographer needs to configure these for tap
  • also should be tested in p4c
@cirocosta cirocosta changed the title make tls configurable via flags make tls configuration configurable via flags Sep 19, 2022
@squeedee
Copy link
Member

Would be nice to provide a command line flags helper and SetupWithManager helper for webhooks to make this re-usable by other teams

@scothis
Copy link
Contributor

scothis commented Sep 22, 2022

Is this something that needs to be configurable, or configured once? The only client for the webhook is the k8s api server, so as long as that client is compatible, we should be ok to configure it once for all installs.

@squeedee
Copy link
Member

@scothis it needs to be configurable. Some people need to be able to downgrade supported versions and ciphers, for example.

@karayim karayim added this to the TAP 1.4 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

4 participants