Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.resources to workload #1049

Open
waciumawanjohi opened this issue Oct 4, 2022 · 2 comments
Open

Add build.resources to workload #1049

waciumawanjohi opened this issue Oct 4, 2022 · 2 comments

Comments

@waciumawanjohi
Copy link
Contributor

Description of problem

A supply chain may want to include a template of a build step. Such a step may require a specifications of resources to allocate to the build process. See for example kpack image use of k8s resource limits/requests (corev1.ResourceRequirements).

Proposed solution

The workload currently has a spec.build.env field. Add a spec.build.resources field.

@waciumawanjohi
Copy link
Contributor Author

This proposal is under discussion by the team.

@squeedee
Copy link
Member

squeedee commented Oct 4, 2022

I am concerned that the workload first class fields becomes a big ball of mud. Already it's not obvious which fields are required in combination with others, and resources, like env, might not always work with a build step.

My preference is something self describing, which is a list of params exposed to the workload by the supply chain, with docs, and in time, with a deterministic, statically analysable contract, eg: I provide a workload with a certain label, and the supply chain can immediately tell me "you forgot params.resources"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants