Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture_local to support timeout? #232

Open
reasonerjt opened this issue Jan 28, 2022 · 2 comments
Open

capture_local to support timeout? #232

reasonerjt opened this issue Jan 28, 2022 · 2 comments

Comments

@reasonerjt
Copy link
Contributor

reasonerjt commented Jan 28, 2022

I integrated crashd in my pipeline, when the test case fails this is run to collect some information:

capture_local(cmd=collectionCmd, file_name="collection.log")

Due to a bug in the backend, the case failed and the collectionCmd was blocked until the pipeline timed out and killed the whole process.

It would be friendlier for this scenario if capture_local can accept a new parm timeout so failure is more explicit.

Not sure the change should be made in this repo or gexe. I'm opening the issue here for tracking.

@vladimirvivien
Copy link
Contributor

@reasonerjt this is a good idea.
I think all commands that interact with a resource (compute, local or remote) should support a timeout value.

@klxfeiyang
Copy link

klxfeiyang commented Mar 9, 2022

@vladimirvivien, bumping this discussion, we would like to utilize the timeout feature as well, because we have observed occasions when crashd would hang for hours collecting logs from specific resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants