Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add BaseVocalDataset that uses vocles #539

Closed
NickleDave opened this issue Jul 8, 2022 · 1 comment
Closed

ENH: add BaseVocalDataset that uses vocles #539

NickleDave opened this issue Jul 8, 2022 · 1 comment
Assignees
Labels
ENH: enhancement enhancement; new feature or request

Comments

@NickleDave
Copy link
Collaborator

related to #446

we do already have a base VocalDataset but it's basically just used for prediction

there should be something like a base Dataset class similar to the hierarchy in torchvision that has an init that expect to get a path to a vocles dataset and then keeps that as an attribute

Two sub-classes would be AudioDataset and SpectrogramDataset, that each return as an __item__ the audio or spectrogram + any corresponding annotation from the row. We could just always return a dict with audio / spect and annot and let annot be None for unannotated data. This removes the need to have a separate dataset for prediction

Then e.g. a BFSongRepo dataset would sub-class the SpectrogramDataset?
But then we'd need to actually provide spectrograms 🤔

@NickleDave NickleDave added the ENH: enhancement enhancement; new feature or request label Jul 8, 2022
@NickleDave NickleDave self-assigned this Jul 8, 2022
@NickleDave
Copy link
Collaborator Author

NickleDave commented Jul 28, 2023

Closing this because

  • I am realizing that the concept of Dataset as used in torch tends to conflate a static set of files with the dynamic series of pre-processing transformations applied to those files at load time; I feel like we should prefer the term "Dataset" to refer to a static set of files and a term like "Pipeline" to refer to a pre-defined set of transformations
  • I decided not to dev vocles further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement enhancement; new feature or request
Projects
None yet
Development

No branches or pull requests

1 participant