Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Warn: direct mutation of existingTags #94

Closed
homersimpsons opened this issue Apr 1, 2020 · 2 comments
Closed

Vue Warn: direct mutation of existingTags #94

homersimpsons opened this issue Apr 1, 2020 · 2 comments

Comments

@homersimpsons
Copy link

Hello, thank you for your awesome component.

I'm using it on a project and came across an issue (that do not break anything).

When using typeahead-url Vue shows a warning:

[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "existingTags"

I guess this is because of the assignation here at least

that.existingTags = JSON.parse(xhttp.responseText);

@AlexMordred
Copy link
Member

Oh, yeah, you're right Thanks, I'll take a look when I have time.

@AlexMordred
Copy link
Member

Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants