Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate / replace sml_transport API #147

Open
r00t- opened this issue Mar 7, 2024 · 0 comments
Open

deprecate / replace sml_transport API #147

r00t- opened this issue Mar 7, 2024 · 0 comments

Comments

@r00t-
Copy link
Collaborator

r00t- commented Mar 7, 2024

the sml_transport API is far too primitive to be useful,
sml_transport_read() does not have any provision to keep state between invocations,
and no way to return more detailed information. (it can only return an int, and only write to stderr (see #17 )

  • we already re-defined the API so that a 0 return means "error": handle read errors and eof #51
  • we can not generate a warning (neither by returning to the caller, nor via stderr - because we can't even keep state) if the data read is being ignored when no start sequence is found (see e.g. no logging vzlogger#633 (comment) )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant