-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Details Block #181
Conversation
I'm a bit conflicted by the name Also I added for now the | (pipe) character for separating multiple values. I could make this an option in which you can enter the split character in Dato, so the content editors can decide on a per block basis what they want to the split character to be. Does this sound like a good idea or overkill? |
Deploying head-start with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @luukbrauckmann! Left small comments.
@@ -0,0 +1,4 @@ | |||
fragment DetailsBlock on DetailsBlockRecord { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to also include the migration for this block in the PR. We might be blocked by #164 by this 🤷 .
@luukbrauckmann you've already made some good iterations on this PR 🙌. As @decrek remarked and as we discussed, we could achieve this functionality as a variation on the Page Partial Block, rather than introducing a new one. We prefer that approach as it reduces the number of components we need to maintain and footprint we provide to developers using Head Start. What prompted the discussion and is another benefit to reusing the Page Partial Block, is that it allows for richer content in the detail list items (like text formatting and links). |
Stale for 3 months. Incomplete implementation: migration script is missing, UI layout can be simplified and overflow isn't handled yet. So closing this PR for now. |
Changes
Associated issue
Resolves #171
How to test
Checklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology