Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Headline Text Uppercase #16

Closed
maya opened this issue Jan 28, 2015 · 4 comments
Closed

Make Headline Text Uppercase #16

maya opened this issue Jan 28, 2015 · 4 comments

Comments

@maya
Copy link

maya commented Jan 28, 2015

Hey there,

How do you change the headline text and source text to uppercase?

Thanks!

Maya

@aithnefeay
Copy link

Hi Maya!

Just to clarify, you mean to transform all input text to uppercase for everyone who loads the app?

@nsonnad
Copy link

nsonnad commented Jan 28, 2015

I added this feature without even knowing that this issue existed! See #17

@maya
Copy link
Author

maya commented Jan 28, 2015

@alfeay I meant exactly what @nsonnad seems to have done already! (We must be on the same wavelength 😄)

I wanted to get the same effect that SB Nation has where what you type gets converted to uppercase: http://apps.voxmedia.com/tools/meme/sbnation/
sbnation

Seems like adding the toggle like @nsonnad did would be even more useful.

@gmac
Copy link
Contributor

gmac commented Feb 1, 2015

Hey @maya, you could do this within the canvas view easily enough... just make that headline uppercase before rendering it onto the canvas. See this:

https://github.com/voxmedia/meme/blob/master/source/javascripts/views/meme-canvas.js#L107

You should be able to chain in a .toUpperCase() call there, as in:

var words = d.headlineText.toUpperCase().split(' ');

@gmac gmac closed this as completed Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants